Owen-CH-Leung commented on code in PR #33135: URL: https://github.com/apache/airflow/pull/33135#discussion_r1285347163
########## airflow/config_templates/config.yml: ########## @@ -2379,7 +2379,7 @@ elasticsearch: elasticsearch_configs: description: ~ options: - use_ssl: Review Comment: In elasticsearch 7, `use_ssl` is an accepted parameter when constructing `ElasticSearch` client. See the following source code : https://github.com/elastic/elasticsearch-py/blob/7.14/elasticsearch/client/__init__.py#L113 However, in elasticsearch 8, it no longer accepts `use_ssl` parameter. See the following source code: https://github.com/elastic/elasticsearch-py/blob/8.9/elasticsearch/_sync/client/__init__.py#L129 Therefore to make the testsuite compile with the ES8 , I use `http_compress` as the argument (which is one of the accepted arguments for constructing ES client -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
