Owen-CH-Leung commented on PR #33135: URL: https://github.com/apache/airflow/pull/33135#issuecomment-1667141806
> Looks good, but it needs a bit "surrounding changes" and "context". > > I think we need to think a bit carefully about the change/migration (configs?) -and soem changelog documentation should be addded explaining what's going on and explaining context. > > The Elasticsearch config can. now be moved to provider - this is where it belongs. We should keep the pre-2.7 defaults in wiki.apache.org/confluence/display/AIRFLOW/AIP-36+DAG+Versioning but the whole "elasticsearch" config should be moved to provider.yaml - same as celery, kubernetes and others. Thanks. I'll some more contexts into changelog soon. For moving elasticsearch config, do you mean the following lines should be moved to `provider.yaml` ? https://github.com/apache/airflow/blob/main/airflow/config_templates/config.yml#L2396-L2410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
