Owen-CH-Leung commented on code in PR #33135:
URL: https://github.com/apache/airflow/pull/33135#discussion_r1285890864


##########
airflow/providers/elasticsearch/CHANGELOG.rst:
##########
@@ -27,6 +27,17 @@
 Changelog
 ---------
 
+5.1.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+.. note::
+  Upgrade to ElasaticSearch 8. The ElasticsearchTaskHandler & 
ElasticsearchSQLHook will now use ElasticSearch 8 package.
+  This also means that the release drops support for ElasticSearch 7 and below 
and will no longer work with
+  ElasticSearch database that is below version 8.

Review Comment:
   Sorry - what I'm trying to say is that this release will drop support for 
ElasticSearch database version 7 or below since `elasticsearch 8` will not work 
with DB version below 8 (i.e. airflow users should also upgrade their ES 
database to version 8 to ensure compatibility). I wrote this because I read the 
following doc and learn that `Elasticsearch language clients are only backwards 
compatible with default distributions and without guarantees made`
   
   https://elasticsearch-py.readthedocs.io/en/stable/
   
   Airflow-wise, nothing should really get broken



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to