potiuk commented on code in PR #33135: URL: https://github.com/apache/airflow/pull/33135#discussion_r1286234103
########## airflow/providers/elasticsearch/CHANGELOG.rst: ########## @@ -27,6 +27,17 @@ Changelog --------- +5.1.0 +..... + +Breaking changes +~~~~~~~~~~~~~~~~ + +.. note:: + Upgrade to ElasaticSearch 8. The ElasticsearchTaskHandler & ElasticsearchSQLHook will now use ElasticSearch 8 package. + This also means that the release drops support for ElasticSearch 7 and below and will no longer work with + ElasticSearch database that is below version 8. Review Comment: Yeah. @eladkal is right - dependency change is not a reason for major bump - even if it is such a "big" dependency. This very clear in https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api: > What should I do if I update my own dependencies without changing the public API? > That would be considered compatible since it does not affect the public API. Software that explicitly depends on the same dependencies as your package should have their own dependency specifications and the author will notice any conflicts. Determining whether the change is a patch level or minor level modification depends on whether you updated your dependencies in order to fix a bug or introduce new functionality. We would usually expect additional code for the latter instance, in which case it’s obviously a minor level increment. ########## airflow/providers/elasticsearch/CHANGELOG.rst: ########## @@ -27,6 +27,17 @@ Changelog --------- +5.1.0 +..... + +Breaking changes +~~~~~~~~~~~~~~~~ + +.. note:: + Upgrade to ElasaticSearch 8. The ElasticsearchTaskHandler & ElasticsearchSQLHook will now use ElasticSearch 8 package. + This also means that the release drops support for ElasticSearch 7 and below and will no longer work with + ElasticSearch database that is below version 8. Review Comment: Yeah. @eladkal is right - dependency change is not a reason for major bump - even if it is such a "big" dependency. This very clear in https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api: > What should I do if I update my own dependencies without changing the public API? > That would be considered compatible since it does not affect the public API. Software that explicitly depends on the same dependencies as your package should have their own dependency specifications and the author will notice any conflicts. Determining whether the change is a patch level or minor level modification depends on whether you updated your dependencies in order to fix a bug or introduce new functionality. We would usually expect additional code for the latter instance, in which case it’s obviously a minor level increment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
