eladkal commented on code in PR #33219: URL: https://github.com/apache/airflow/pull/33219#discussion_r1288421445
########## airflow/providers/amazon/aws/hooks/sagemaker_notebook.py: ########## Review Comment: I'm not sure if file length is a concern? Developers mostly work with IDEs and use auto complete thus having all classes related to a service in one place is a big plus. I think the leading principle of where we place classes is how users look them up. We should optimise for easy discovery. Is it native for a user to look up the class in `sagemaker` file with the other operators or in a separated `sagemaker_notebook` I'm not saying we should change it I'm raising this question and I'm OK with any decision AWS wants to take here (As part of the shared-governance model of provider code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
