potiuk commented on code in PR #33281:
URL: https://github.com/apache/airflow/pull/33281#discussion_r1289818066
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -98,6 +98,15 @@ def __init__(
log_id_template: str | None = None,
):
es_kwargs = es_kwargs or {}
+ # For elasticsearch>8,arguments like retry_timeout have changed for
elasticsearch to retry_on_timeout
+ # in Elasticsearch() compared to previous versions.
+ # Read more at:
https://elasticsearch-py.readthedocs.io/en/v8.8.2/api.html#module-elasticsearch
+ if es_kwargs:
+ retry_timeout = es_kwargs.get("retry_timeout")
Review Comment:
I think it indeed HAS potential of breaking things. If we can make it
"reasonably compatible" - i.e. fix back-compatibilities that we know and smooth
the migration, that would be great, but I would be for marking the next ES
release as MAJOR regardless cc: @eladkal
Also there is a little twist to it. Unless I am mistaken, I think
elasticsearch handler integration was anyhow broken and not working before :) .
So well. it could also be seen as bugfix :P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
