utkarsharma2 commented on code in PR #33281:
URL: https://github.com/apache/airflow/pull/33281#discussion_r1289849833
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -98,6 +98,15 @@ def __init__(
log_id_template: str | None = None,
):
es_kwargs = es_kwargs or {}
+ # For elasticsearch>8,arguments like retry_timeout have changed for
elasticsearch to retry_on_timeout
+ # in Elasticsearch() compared to previous versions.
+ # Read more at:
https://elasticsearch-py.readthedocs.io/en/v8.8.2/api.html#module-elasticsearch
+ if es_kwargs:
+ retry_timeout = es_kwargs.get("retry_timeout")
Review Comment:
@eladkal I'm not entirely sure, but the below code was part of airflow's
codebase which led to the issue because of upgrade -
https://github.com/apache/airflow/blob/01a6c1e7f8b0ed736d7c6f661e0c29ec023016b2/chart/values.yaml#L2149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
