uranusjr commented on code in PR #33357:
URL: https://github.com/apache/airflow/pull/33357#discussion_r1292952610
##########
airflow/models/dag.py:
##########
@@ -3555,16 +3555,26 @@ def set_is_paused(self, is_paused: bool,
including_subdags: bool = True, session
def deactivate_deleted_dags(
cls,
alive_dag_filelocs: Container[str],
+ processor_subdir: str | None = None,
Review Comment:
Can we just make this a required argument? From what I can tell this is not
used anywhere else, and although this is not explicitly marked as internal, I
don’t think there’s reasonable use case to interact with DagModel directly.
##########
airflow/models/dag.py:
##########
@@ -3555,16 +3555,26 @@ def set_is_paused(self, is_paused: bool,
including_subdags: bool = True, session
def deactivate_deleted_dags(
cls,
alive_dag_filelocs: Container[str],
+ processor_subdir: str | None = None,
Review Comment:
Can we just make this a required argument? From what I can tell this is not
used anywhere else, and although this is not explicitly marked as internal, I
don’t think there’s reasonable use case to interact with DagModel directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
