pierrejeambrun commented on code in PR #33357:
URL: https://github.com/apache/airflow/pull/33357#discussion_r1293809443


##########
airflow/models/dag.py:
##########
@@ -3555,16 +3555,26 @@ def set_is_paused(self, is_paused: bool, 
including_subdags: bool = True, session
     def deactivate_deleted_dags(
         cls,
         alive_dag_filelocs: Container[str],
+        processor_subdir: str | None = None,

Review Comment:
   Good idea. I double checked but indeed this is almost never used, only here 
and in 1 test that I adjusted.
   
   We can even narrow the type to just `str` as `get_dag_directory` guarantee a 
str value as input.
   
   
[Done](https://github.com/apache/airflow/pull/33357/commits/a6d11b4ac01127bf2dd789ccb5c5170fda3c9cae)
 :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to