ferruzzi commented on issue #33426: URL: https://github.com/apache/airflow/issues/33426#issuecomment-1680952995
That's very interesting that this came up now. I was just having a chat yesterday about how some of the timers emit seconds and others emit milliseconds and we should probably standardize on one or the other. As for this one, changing what is emitted is going to break someone but I agree that it is a bug which should be fixed. We currently have a number of metrics being emitted twice for various reasons, and adding a new metric is both easy and non-breaking. So my suggestion would be: 1. Update the docs to indicate the right formatting, and indicate that it is deprecated. 2. Add a new metric there which emits in milliseconds. Question for @potiuk : How would we go about actually deprecating a metric? We can't do the usual "print a warning" like we do in a method/class/module because that would print constantly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
