potiuk commented on issue #33426:
URL: https://github.com/apache/airflow/issues/33426#issuecomment-1685074172

   > Question for @potiuk : How would we go about actually deprecating a 
metric? We can't do the usual "print a warning" like we do in a 
method/class/module because that would print constantly.
   
   I am not sure you can deprecate metric. The only idea I have is to provide 
new, consistent metrics and disable old ones by default, but allow to enable 
them selectively - by adding them to "enabled_deprecated_metrics" configuration 
list (but print deprecation warning in this case in log when they are emited). 
   
   Another option is that if we all agree that the old metrics is WRONG - we 
treat it as bugfix and change them (also allowing probably to turn them back to 
what they were before - but with emitting deprecation warnings). Might be worth 
to implement some small framework allowing both cases, anticipating future 
cleanups we might want to do .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to