Taragolis commented on PR #33601: URL: https://github.com/apache/airflow/pull/33601#issuecomment-1687169502
@alexbegg thanks for contribution to Pinot Provider. Could you also add missing class attributes to `PinotDbApiHook` and `PinotAdminHook` - `conn_name_attr`: name of attribute which use for connection_id - `default_conn_name`: default connection_id - `conn_type`: type of connection from provider.yaml - `hook_name`: Name in Connection dropdown list Examples: https://github.com/apache/airflow/blob/770228e4c01dd0a36857a2e06689c9105119b2e2/airflow/providers/postgres/hooks/postgres.py#L70-L73 https://github.com/apache/airflow/blob/770228e4c01dd0a36857a2e06689c9105119b2e2/airflow/providers/google/common/hooks/base_google.py#L183-L188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
