alexbegg commented on PR #33601: URL: https://github.com/apache/airflow/pull/33601#issuecomment-1689374460
I have added those missing args, however I noticed some oddities with this provider: - The example DAG is seeming to confuse the use of an Operator and of a Hook. If you see in this example, a `task_id` is defined for a hook, which is not correct (this argument will just be ignored). The hook's params are used almost as if they were operator params... https://github.com/apache/airflow/blob/487b174073c01e03ae64760405a8d88f6a488ca6/tests/system/providers/apache/pinot/example_pinot_dag.py#L42-L48 - The "Operators" documentation page for the provider, https://airflow.apache.org/docs/apache-airflow-providers-apache-pinot/stable/operators.html, shows how to use the hooks in TaskFlow-decorated task functions, instead of actual operators as the page name would suggest. - In the above example code, the hook class is used to execute a command, however shouldn't the hook just be used to initialize a connection and then methods of that hook is used to execute commands? If that is done then we can even add in operators that make use of that hook's method. Should this provider get actual operators, to avoid this confusion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
