potiuk opened a new pull request, #33603:
URL: https://github.com/apache/airflow/pull/33603
Previously we have been using provider.yaml file modification as a sign that
the docker image needs rebuilding when starting image. However just
modification of provider.yaml file is not a sign that the image needs
rebuilding. The image needs rebuilding when provider dependencies changed, but
there are many more reasons why provider.yaml file changed - especially
recently provider.yaml file contains much more information and dependencies are
only part of it. Provider.yaml files can also be modified by release manager
wnen documentation is prepared, but none of the documentation change is a
reason for rebuilding the image.
This PR optimize the check for image building introducing two step process:
* first we check if provider.yaml files changed
* if they did, we regenerate provider dependencies by manully running the
pre-commit script
* then provider_dependencies.json is used instead of all providers to
determine if the image needs rebuilding
This has several nice side effects:
* the list of files that have been modified displayed to the user is
potentially much smaller (no provider.yaml files)
* provider_dependencies.json is regenereated automatically when you run any
breeze command, which means that you do not have to have pre-commit installed
to regenerate it
* the notification "image needs rebuilding" will be printed less frequently
to the user - only when it is really needed
* preparing provider documentation in CI will not trigger image rebuilding
(which might occasionally fail in such case especially when we bring back a
provider from long suspension like it happened in #33574
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
