pankajkoti commented on code in PR #33603:
URL: https://github.com/apache/airflow/pull/33603#discussion_r1301182920
##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -515,6 +515,9 @@ def static_checks(
force_build=force_build,
image_tag=image_tag,
github_repository=github_repository,
+ # for static checks we do not want to regenerate dependencies before
pre-commits are run
+ # we want the pre-commit to do it for us (and fail in case the
dependencies are updated)
Review Comment:
```suggestion
# we want the pre-commit to do it for us (and raise failures if any
only when dependencies are updated)
```
otherwise, it may sound like it will always fail when dependencies are
updated? 🤔
##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -515,6 +515,9 @@ def static_checks(
force_build=force_build,
image_tag=image_tag,
github_repository=github_repository,
+ # for static checks we do not want to regenerate dependencies before
pre-commits are run
+ # we want the pre-commit to do it for us (and fail in case the
dependencies are updated)
Review Comment:
```suggestion
# we want the pre-commit to do it for us (and raise failures if any
only when dependencies are updated)
```
otherwise, it may sound like it will always fail when dependencies are
updated? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
