vincbeck commented on code in PR #33614:
URL: https://github.com/apache/airflow/pull/33614#discussion_r1301869127
##########
airflow/providers/amazon/aws/operators/appflow.py:
##########
@@ -58,29 +59,33 @@ class AppflowBaseOperator(BaseOperator):
ui_color = "#2bccbd"
+ template_fields = ("flow_name", "source", "source_field", "filter_date")
+
UPDATE_PROPAGATION_TIME: int = 15
def __init__(
self,
- source: str,
flow_name: str,
flow_update: bool,
+ source: str | None = None,
Review Comment:
But other operators have the same issue below. e.g. `AppflowRunOperator `.
Usually we force using operator names in operators but I guess we missed this
one :|
##########
airflow/providers/amazon/aws/operators/appflow.py:
##########
@@ -58,29 +59,33 @@ class AppflowBaseOperator(BaseOperator):
ui_color = "#2bccbd"
+ template_fields = ("flow_name", "source", "source_field", "filter_date")
+
UPDATE_PROPAGATION_TIME: int = 15
def __init__(
self,
- source: str,
flow_name: str,
flow_update: bool,
+ source: str | None = None,
Review Comment:
But other operators have the same issue below. e.g. `AppflowRunOperator `.
Usually we force using parameter names in operators but I guess we missed this
one :|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
