vincbeck commented on code in PR #33614:
URL: https://github.com/apache/airflow/pull/33614#discussion_r1301935970
##########
airflow/providers/amazon/aws/operators/appflow.py:
##########
@@ -58,29 +59,33 @@ class AppflowBaseOperator(BaseOperator):
ui_color = "#2bccbd"
+ template_fields = ("flow_name", "source", "source_field", "filter_date")
+
UPDATE_PROPAGATION_TIME: int = 15
def __init__(
self,
- source: str,
flow_name: str,
flow_update: bool,
+ source: str | None = None,
source_field: str | None = None,
filter_date: str | None = None,
poll_interval: int = 20,
+ max_attempts: int = 60,
aws_conn_id: str = "aws_default",
region: str | None = None,
wait_for_completion: bool = True,
**kwargs,
) -> None:
super().__init__(**kwargs)
- if source not in SUPPORTED_SOURCES:
+ if source is not None and source not in SUPPORTED_SOURCES:
raise ValueError(f"{source} is not a supported source (options:
{SUPPORTED_SOURCES})!")
self.filter_date = filter_date
self.flow_name = flow_name
self.source = source
self.source_field = source_field
self.poll_interval = poll_interval
+ self.max_attempts = max_attempts
Review Comment:
docstring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]