hussein-awala commented on code in PR #33712:
URL: https://github.com/apache/airflow/pull/33712#discussion_r1305482708
##########
airflow/providers/amazon/aws/operators/ecs.py:
##########
@@ -476,7 +476,7 @@ def __init__(
number_logs_exception: int = 10,
wait_for_completion: bool = True,
waiter_delay: int = 6,
- waiter_max_attempts: int = 100,
+ waiter_max_attempts: int = sys.maxsize, # Unless specified timeout is
managed by airflow
Review Comment:
There are two things here:
1. Changing the default value to infinite could be a breaking change (cc:
@eladkal )
2. If it's okay to change it, the best way is to make it None and replace
the loop in the Trigger with `while True` when it's None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
