eladkal commented on code in PR #33712:
URL: https://github.com/apache/airflow/pull/33712#discussion_r1305655656
##########
airflow/providers/amazon/aws/operators/ecs.py:
##########
@@ -476,7 +476,7 @@ def __init__(
number_logs_exception: int = 10,
wait_for_completion: bool = True,
waiter_delay: int = 6,
- waiter_max_attempts: int = 100,
+ waiter_max_attempts: int = sys.maxsize, # Unless specified timeout is
managed by airflow
Review Comment:
> Agree it might be seen as breaking but looking at the problem description
I think the previous change was accidentally breaking (i.e. changing from
effectively infinite to finite) and this one is simply a bugfix restoring it.
Then I can accept this as non breaking change. Yet requesting to add a note
explaining it in the top of the CHANGELOG. I will bake it to the proper release
version during release process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
