vincbeck commented on code in PR #33213: URL: https://github.com/apache/airflow/pull/33213#discussion_r1305851514
########## airflow/auth/managers/models/resource_details.py: ########## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from dataclasses import dataclass + + +@dataclass +class ResourceDetails: + """ + Represents the details of a resource. + + All fields must be optional. These details can be used in authorization decision. + """ + + id: str | None = None Review Comment: I definitely dont like having multiple `is_authorized` methods. I really like the fact we have one entry point for authorization: `is_authorized`. It makes it cleaner and simpler to me (very subjective I know). What if we use dictionary? How could we use dictionary and have only one method `is_authorized`? > Having a dictionary (and well defined structure of it "per resource typ" - seems more complex, but in fact it is esier. we are not tied with fields of ResourceDetails. How are you thinking achieving this? Something like [schemadict](https://pypi.org/project/schemadict/) and we would have one schema per resource type? Performance wise I am not sure this is the right decision since `is_authorized` is called quite a lot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
