potiuk commented on code in PR #33213: URL: https://github.com/apache/airflow/pull/33213#discussion_r1306034431
########## airflow/auth/managers/models/resource_details.py: ########## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from dataclasses import dataclass + + +@dataclass +class ResourceDetails: + """ + Represents the details of a resource. + + All fields must be optional. These details can be used in authorization decision. + """ + + id: str | None = None Review Comment: > Even if we have 10, does it make sense to have is_authorized_variable, is_authorized_connection, is_authorized_connection, is_authorized_configuration which most likely will have their own ResourceDetails which will reference only the ID? Not at all. The methods for connection, configuration and everything else that just need id can be: ``` is_authorised_connection(connection_id: str) is_authorised_configuration(configuration_id: str) is_authorised_variable(variable_id: str) ``` I did not call for N resource types, just for N methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
