Taragolis commented on code in PR #33780: URL: https://github.com/apache/airflow/pull/33780#discussion_r1306623278
########## airflow/providers/amazon/aws/hooks/ecr.py: ########## @@ -20,11 +20,14 @@ import base64 import logging from dataclasses import dataclass -from datetime import datetime +from typing import TYPE_CHECKING from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook from airflow.utils.log.secrets_masker import mask_secret +if TYPE_CHECKING: + from datetime import datetime Review Comment: I would rather create pre-commit around deny-list, rather that around all stuff. Just because `if TYPE_CHECKING` it is a hack and put everything under this block might add more pain rather than solve it, especially it valid in the project with 100k+ lines of code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
