uranusjr commented on code in PR #33934:
URL: https://github.com/apache/airflow/pull/33934#discussion_r1311060501
##########
airflow/utils/python_virtualenv.py:
##########
@@ -41,14 +41,14 @@ def _generate_virtualenv_cmd(tmp_dir: str, python_bin: str,
system_site_packages
def _generate_pip_install_cmd_from_file(
tmp_dir: str, requirements_file_path: str, pip_install_options: list[str]
) -> list[str]:
- cmd = [f"{tmp_dir}/bin/pip", "install"] + pip_install_options + ["-r"]
- return cmd + [requirements_file_path]
+ cmd = [f"{tmp_dir}/bin/pip", "install", *pip_install_options, "-r"]
+ return [*cmd, requirements_file_path]
Review Comment:
Saves a superfulous list
```suggestion
return [f"{tmp_dir}/bin/pip", "install", *pip_install_options, "-r",
requirements_file_path]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
