uranusjr commented on code in PR #33934:
URL: https://github.com/apache/airflow/pull/33934#discussion_r1311097068
##########
airflow/models/dag.py:
##########
@@ -1699,7 +1699,7 @@ def _get_task_instances(
if include_subdags:
# Crafting the right filter for dag_id and task_ids combo
conditions = []
- for dag in self.subdags + [self]:
+ for dag in [*self.subdags, self]:
Review Comment:
A big chunk of this would come from `import itertools` though, which would
not be relevant in Airflow since the module is already imported in a lot of
places. I would not be surprised if `*` is still best for small lists though,
since the itertools version still needs to build an additional list (of a
single item).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
