jaegwonseo commented on code in PR #33796:
URL: https://github.com/apache/airflow/pull/33796#discussion_r1313832765
##########
airflow/providers/apache/druid/CHANGELOG.rst:
##########
@@ -27,6 +27,19 @@
Changelog
---------
+4.0.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add druid ingestion connection test And expose druid ingest hook (#33795)``
+
+.. note::
+ The connection type of Druid has been separated into two(druid_broker,
druid_ingest)
Review Comment:
@eladkal
I'm not an English speaker, so I'm not sure if the following mention is
accurate. Please review this
```
The connection type of Druid has been separated into two(Druid Broker, Druid
Ingest). Please perform one of the two methods listed below.
1. update druid connect type to (Druid Broker, Druid Ingest) on UI screen
(Admin/Connections)
2. run command airflow db migrate
```
**but in second case, airflow db migrate doesn't support update connect
type** so we need implement this.
my suggestion is write first option only, and add an implementation to check
the version of the Druid provider in the db migrate process, so that we can
upgrade the Druid connector type when needed in Airflow in other issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
