jaegwonseo commented on code in PR #33796:
URL: https://github.com/apache/airflow/pull/33796#discussion_r1314256500


##########
airflow/providers/apache/druid/hooks/druid.py:
##########
@@ -149,6 +154,20 @@ def submit_indexing_job(
 
         self.log.info("Successful index")
 
+    def test_connection(self) -> tuple[bool, str]:
+        try:
+            conn = self.get_connection(self.druid_ingest_conn_id)
+            host = conn.host
+            port = conn.port
+            # ref : 
https://druid.apache.org/docs/latest/operations/api-reference/#tasks
+            response = 
requests.get(f"http://{host}:{port}/druid/indexer/v1/tasks";)

Review Comment:
   @hussein-awala 
   The Druid Broker Hook overrides the DbApiHook, but the test connection is 
not implemented to use authentication information
   
https://github.com/apache/airflow/blob/main/airflow/providers/common/sql/hooks/sql.py#L550
   
   So, I think adding authentication information to the Druid hook (broker, 
ingest) is handled in another issue
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to