Taragolis commented on code in PR #34037: URL: https://github.com/apache/airflow/pull/34037#discussion_r1313885826
########## airflow/config_templates/unit_tests.cfg: ########## @@ -59,6 +59,8 @@ unit_test_mode = True killed_task_cleanup_time = 5 # We only allow our own classes to be deserialized in tests allowed_deserialization_classes = airflow\..* tests\..* +# mocks from unittest.mock work correctly in subprocesses only if they are created by "fork" method +mp_start_method = fork Review Comment: Use or not `unit_tests.cfg` controlled by [`AIRFLOW__CORE__UNIT_TEST_MODE`](https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#unit-test-mode) and will affect all Airflow users who use this variable in their tests In opposite `conftest.py` only for internal Airflow Tests, and only affect contributors to Airflow, who might run tests in Breeze. In additional some tests could override `AIRFLOW__CORE__UNIT_TEST_MODE` to False. That is my thoughts, lets wait what he other says. Maybe it could really be better place it in `unit_tests.cfg` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
