Bisk1 commented on code in PR #34037:
URL: https://github.com/apache/airflow/pull/34037#discussion_r1314275322


##########
airflow/config_templates/unit_tests.cfg:
##########
@@ -59,6 +59,8 @@ unit_test_mode = True
 killed_task_cleanup_time = 5
 # We only allow our own classes to be deserialized in tests
 allowed_deserialization_classes = airflow\..* tests\..*
+# mocks from unittest.mock work correctly in subprocesses only if they are 
created by "fork" method
+mp_start_method = fork

Review Comment:
   OK,I moved the change to `conftest.py` anded condition for MacOS only.
   I looked at other tests and didn't notice any negative impact of the tests 
on my machine.



##########
airflow/config_templates/unit_tests.cfg:
##########
@@ -59,6 +59,8 @@ unit_test_mode = True
 killed_task_cleanup_time = 5
 # We only allow our own classes to be deserialized in tests
 allowed_deserialization_classes = airflow\..* tests\..*
+# mocks from unittest.mock work correctly in subprocesses only if they are 
created by "fork" method
+mp_start_method = fork

Review Comment:
   OK,I moved the change to `conftest.py` anded condition for MacOS only.
   I looked at other tests and didn't notice any negative impact of the tests 
on my machine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to