Seokyun-Ha commented on code in PR #34071:
URL: https://github.com/apache/airflow/pull/34071#discussion_r1316866421
##########
airflow/providers/databricks/hooks/databricks.py:
##########
@@ -114,6 +116,53 @@ def from_json(cls, data: str) -> RunState:
return RunState(**json.loads(data))
+class ClusterState:
+ """Utility class for the cluster state concept of Databricks cluster."""
+
+ CLUSTER_LIFE_CYCLE_STATES = [
+ "PENDING",
+ "RUNNING",
+ "RESTARTING",
+ "RESIZING",
+ "TERMINATING",
+ "TERMINATED",
+ "ERROR",
+ "UNKNOWN",
+ ]
+
+ def __init__(self, state: str = "", state_message: str = "", *args,
**kwargs) -> None:
+ self.state = state
+ self.state_message = state_message
+
+ @property
+ def is_terminal(self) -> bool:
+ """True if the current state is a terminal state."""
+ if self.state not in self.CLUSTER_LIFE_CYCLE_STATES:
+ raise AirflowException(f"Unexpected cluster life cycle state:
{self.state}")
Review Comment:
I moved unexpected run/cluster state checking to `__init__()` level. Thanks!
👍
##########
airflow/providers/databricks/hooks/databricks.py:
##########
@@ -114,6 +116,53 @@ def from_json(cls, data: str) -> RunState:
return RunState(**json.loads(data))
+class ClusterState:
+ """Utility class for the cluster state concept of Databricks cluster."""
+
+ CLUSTER_LIFE_CYCLE_STATES = [
+ "PENDING",
+ "RUNNING",
+ "RESTARTING",
+ "RESIZING",
+ "TERMINATING",
+ "TERMINATED",
+ "ERROR",
+ "UNKNOWN",
+ ]
+
+ def __init__(self, state: str = "", state_message: str = "", *args,
**kwargs) -> None:
+ self.state = state
+ self.state_message = state_message
+
+ @property
+ def is_terminal(self) -> bool:
+ """True if the current state is a terminal state."""
+ if self.state not in self.CLUSTER_LIFE_CYCLE_STATES:
+ raise AirflowException(f"Unexpected cluster life cycle state:
{self.state}")
Review Comment:
I moved unexpected run/cluster state checking to `__init__()` level. Thanks!
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
