potiuk commented on code in PR #34119: URL: https://github.com/apache/airflow/pull/34119#discussion_r1317854061
########## airflow/providers/elasticsearch/log/es_task_handler.py: ########## @@ -56,6 +58,18 @@ USE_PER_RUN_LOG_ID = hasattr(DagRun, "get_log_template") +VALID_ES_CONFIG_KEYS = set(inspect.signature(elasticsearch.Elasticsearch.__init__).parameters.keys()) Review Comment: > I've always don't know about such stuff in Top Level on the one side it should imported only once, in the other we might save for import time and move it into the get_es_kwargs_from_config yeah. I think we are importing a lot more here and this inspect will be rather cheap comparing with importing the whole es stack. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
