potiuk commented on code in PR #34119: URL: https://github.com/apache/airflow/pull/34119#discussion_r1317869760
########## airflow/providers/elasticsearch/log/es_task_handler.py: ########## @@ -56,6 +58,18 @@ USE_PER_RUN_LOG_ID = hasattr(DagRun, "get_log_template") +VALID_ES_CONFIG_KEYS = set(inspect.signature(elasticsearch.Elasticsearch.__init__).parameters.keys()) Review Comment: > I don't know what we should exactly do with that parameter. IMO, if we yanked 5.0.0/5.0.1 then we could extend breaking changes and info that user should change retry_timeout to retry_on_timeout for keep previous behaviour I included it in the `get_es_kwargs_from_config` method. > The other things, since it method of the class inspect also include self. Possibly minor thing and could be ignored Yep. Removed it and added test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
