benbuckman commented on issue #30264: URL: https://github.com/apache/airflow/issues/30264#issuecomment-1710753268
Can this be re-opened? We also encountered this, and were very surprised that the `on_failure_callback` was not fired, because it only runs on _task_ failure, but the task that was running when the timeout was hit was _skipped_ not _failed_. First, that behavior seems wrong: if a task is taking too long and hits the `dagrun_timeout`, I would expect that task (as well as the DAG) to fail. Second, @hussein-awala [wrote](https://github.com/apache/airflow/issues/30264#issuecomment-1483841461), > I don't see the need to run the failure callback in every stopped task, the **dag failure callback** is enough to handle this case But what is the "dag failure callback"? I don't see a callback like that in these docs: https://airflow.apache.org/docs/apache-airflow/stable/administration-and-deployment/logging-monitoring/callbacks.html (Do you mean the `sla_miss_callback`? i.e. set the DAG's SLA to the same as the DAG's `dagrun_timeout`?) A DAG-level failure callback would be very nice to have. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
