hussein-awala commented on code in PR #34127:
URL: https://github.com/apache/airflow/pull/34127#discussion_r1320219097
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -388,7 +388,7 @@ def fetch_container_logs(
before=before_log(self.log, logging.INFO),
)
def consume_logs(
- *, since_time: DateTime | None = None, follow: bool = True,
termination_timeout: int = 120
+ *, logs: PodLogsConsumer
Review Comment:
I disagree with @potiuk, the public interface documentation is only valid
for Airflow core, but for the providers, from what I've seen, all public
classes/methods should be updated without any breaking change, except if we
want to create a new major version.
IMHO this is a breaking change, and the bug could (and should) be fixed in a
backward compatible way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
