dkim010 commented on code in PR #34127:
URL: https://github.com/apache/airflow/pull/34127#discussion_r1328819350
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -403,16 +407,17 @@ def consume_logs(
"""
last_captured_timestamp = None
try:
- logs = self.read_pod_logs(
- pod=pod,
- container_name=container_name,
- timestamps=True,
- since_seconds=(
- math.ceil((pendulum.now() -
since_time).total_seconds()) if since_time else None
- ),
- follow=follow,
- post_termination_timeout=termination_timeout,
- )
+ if not logs:
Review Comment:
> Did you have the opportunity to test it?
Yes, I am using the airflow applied this patch and checked that there is no
duplicated logs.
---
I added a test case to check whether the PodLogsConsumer is reused correctly
and there are no duplicated logs both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
