shahar1 commented on code in PR #33786:
URL: https://github.com/apache/airflow/pull/33786#discussion_r1320694908
##########
airflow/providers/google/cloud/operators/vertex_ai/custom_job.py:
##########
@@ -1111,10 +1129,19 @@ def __init__(
self,
*,
script_path: str,
+ region: str,
requirements: Sequence[str] | None = None,
+ dataset_id: str | None = None,
+ impersonation_chain: str | Sequence[str] | None = None,
**kwargs,
) -> None:
- super().__init__(**kwargs)
+ # FIXME: allow assignments in the super() constructor
Review Comment:
I need to figure out how to deal with attributes that are initialized at the
parent's level -
Let's say that the parent has a mandatory template field `foo`, it will be
init. by `super().__init__(foo=foo)`. As of the current implementation, I also
need to set it in the class itself to detect it in the pre-commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
