shahar1 commented on PR #33786: URL: https://github.com/apache/airflow/pull/33786#issuecomment-1712935380
@potiuk @eladkal The PR is still in the oven, yet I have a couple of questions: 1. Can I assume that the name of a template argument (e.g., `foo`) is the same as its respective attribute (`self.foo`)? Otherwise, checking if it's assigned to the appropriate attribute becomes a very hard task (instead of simply recognizing pattern like `self.foo = foo`, which is easier to isolate from the code). I know it is quite strict, but I see no other choice. 2. To what depth should I try diving in when checking the usages of the template argument in the scope of this PR? Python's grammar is pretty [rich](https://docs.python.org/3/library/ast.html#abstract-grammar) - Does it sound reasonable to limit it to conditions or/and loops at this point? 3. Please take a look at the limitations that I mentioned in the PR's content - can we live with them for now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
