xgao1023 commented on code in PR #32520:
URL: https://github.com/apache/airflow/pull/32520#discussion_r1320749075
##########
airflow/models/taskinstance.py:
##########
@@ -436,6 +436,7 @@ class TaskInstance(Base, LoggingMixin):
next_method = Column(String(1000))
next_kwargs = Column(MutableDict.as_mutable(ExtendedJSON))
+ _task_display_name = Column("task_display_name", String(2000), default="")
Review Comment:
> The model is defined as far as I understand the code to use the `task_id`
if no display name is given. This is good as it saved space in the DB (if no
display name given) as well as allows migration (else during migration the
column needs to be filled).
> I'd propose to keep it this way.
Do you mean we should allow the DB colomn Nullable and fallback to `task_id`
if no display name is null (None in Python)?
What if display_name is an empty string but not None, should we fallback to
`task_id` or use empty string as it?
@uranusjr What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
