xgao1023 commented on code in PR #32520:
URL: https://github.com/apache/airflow/pull/32520#discussion_r1324131944
##########
airflow/models/taskinstance.py:
##########
@@ -436,6 +436,7 @@ class TaskInstance(Base, LoggingMixin):
next_method = Column(String(1000))
next_kwargs = Column(MutableDict.as_mutable(ExtendedJSON))
+ _task_display_name = Column("task_display_name", String(2000), default="")
Review Comment:
I understand your point.
I think @jens-scheffler-bosch is considering from the aspect of database
storage.
Actually I'm ok with either
1) make it nullable, or
2) make it not nullable with default "" (empty string)
I think both proposals above should fallback to task_id/dag_id when display
name is empty/null.
I personally prefer 1) which is my original change because it's more
friendly to migrations. But they're not too much different and I'm perfectly ok
with 2.
Let's try to make a decision and move forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
