potiuk commented on PR #34254: URL: https://github.com/apache/airflow/pull/34254#issuecomment-1712790563
> In general looks good except `--wait-timeout` which we do not support in the CI yet > Ah yeah. That's why we keep the "min" version of docker in CI to make sure our "min requirements" are good. Yeah. I will remove the timeout altogether. > In additional I tried to find possibility to replace subprocess + Docker by [python-on-whales](https://github.com/gabrieldemarmiesse/python-on-whales) which I personally found more resilient way to build applications/utils on top of docker stack. So I have a plan to replace subprocess in docker-compose tests and after have a look is it support every feature, so we could try to replace stuff in breeze This is a cool project :). Thanks for finding it and pointing to it. It seems to very nicely address the need we have - where we do not want to use the API of docker, but docker CLI (and it seem to have support for podman and nerdctl out-of-the-box which is cool. One small watch-out. We currently have the `run_command` implemented in Breeze to support `--dry-run` and `--verbose` commands: both of them super useful for testing and understanding what's going on under the hood. Generally both print generall copy-pasteable command that Breeze runs so that you can run it manually and play with it. I hope we can make `python-on-whales` support similar feature (and if not - maybe we can contribute it before we start using it). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
