Taragolis commented on PR #34254:
URL: https://github.com/apache/airflow/pull/34254#issuecomment-1712797933

   > One small watch-out. We currently have the run_command implemented in 
Breeze to support --dry-run and --verbose commands: both of them super useful 
for testing and understanding what's going on under the hood. Generally both 
print copy-pasteable command that Breeze runs so that you can run it manually 
and play with it (including env vars). I hope we can make python-on-whales 
support similar feature (and if not - maybe we can contribute it before we 
start using it).
   
   Yep, I think better to inspect breeze (maybe I can do on the next week) and 
collect all stuff which we lost in case of switch to `python-on-whales` and 
after decide is it worthwhile, new features are cool unless you lost something 
important.
   
   I have experience with replace something simple and legacy, like replace 
couple of files which manually generate command for subprocess or shell scripts 
which run commands + jq for parse output in this case it is cool. But with 
breeze it just might not as we expects and just make maintainers sad. E.g. in 
theory `--dry-run` could be replaced by simple fake cli command which just 
print command and provide it in 
[client_call](https://gabrieldemarmiesse.github.io/python-on-whales/docker_client/)
 but in practice we never know until try it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to