vincbeck commented on code in PR #34317: URL: https://github.com/apache/airflow/pull/34317#discussion_r1324610764
########## airflow/www/auth.py: ########## @@ -17,56 +17,157 @@ from __future__ import annotations from functools import wraps -from typing import Callable, Sequence, TypeVar, cast +from typing import TYPE_CHECKING, Callable, TypeVar, cast -from flask import current_app, flash, g, redirect, render_template, request +from flask import flash, g, redirect, render_template, request +from airflow.auth.managers.models.resource_details import ( + ConnectionDetails, + DagAccessEntity, + DagDetails, +) from airflow.configuration import conf from airflow.utils.net import get_hostname from airflow.www.extensions.init_auth_manager import get_auth_manager +if TYPE_CHECKING: + from airflow.auth.managers.base_auth_manager import ResourceMethod + from airflow.models import Connection Review Comment: Noted. That'd be worth writing a pre-commit script for such things :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
