uranusjr commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1337905995
##########
airflow/auth/managers/fab/fab_auth_manager.py:
##########
@@ -209,7 +209,9 @@ def is_authorized_dag(
resource_type = self._get_fab_resource_type(access_entity)
if method == "GET":
- return self._is_authorized(method=method,
resource_type=resource_type, user=user)
+ return self._is_authorized_dag(
+ method="GET", details=details, user=user
+ ) and self._is_authorized(method=method,
resource_type=resource_type, user=user)
Review Comment:
```suggestion
if not self._is_authorized_dag(method="GET",
details=details, user=user):
return False
return self._is_authorized(method=method,
resource_type=resource_type, user=user)
```
Let’s break this, the statement is quite long.
##########
airflow/auth/managers/fab/fab_auth_manager.py:
##########
@@ -209,7 +209,9 @@ def is_authorized_dag(
resource_type = self._get_fab_resource_type(access_entity)
if method == "GET":
- return self._is_authorized(method=method,
resource_type=resource_type, user=user)
+ return self._is_authorized_dag(
+ method="GET", details=details, user=user
+ ) and self._is_authorized(method=method,
resource_type=resource_type, user=user)
Review Comment:
```suggestion
if not self._is_authorized_dag(method="GET",
details=details, user=user):
return False
return self._is_authorized(method=method,
resource_type=resource_type, user=user)
```
Let’s break this, the statement is quite long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
