potiuk commented on PR #34324: URL: https://github.com/apache/airflow/pull/34324#issuecomment-1718323312
> I don't see a "Testing" doc in the executor hierarchy? I'm likely missing something though 👀 <img width="851" alt="Screenshot 2023-09-13 at 23 06 11" src="https://github.com/apache/airflow/assets/595491/acdacc51-415d-4296-af58-89764c324282";> What I see: * Testing .... * Debugging .... * DebugExecutor (Deprecated) I think it's because those files are wrongly placed :) > This section actually already existed before I updated it (my changes start at "Writing Your Own Executor"), but I can make this change anyway while I'm here. Yep. It's all "Let's make the doc complete and makes sensee" rather than "Let's preserve what was wrong before" > I did think of this, but unlike custom operators, it's quite a large piece of code to even have a boilerplate. I was thinking of adding a very pseudo code snippet, but wasn't convinced that it would be helpful beyond folks just having a look at any of the existing community executors which all implement the BaseExecutor interface. Interested to hear what others think! Agree. It should be enough to say ("look at existing executor's implementation to take inspiration" - which I think is already there, so unless there is some nicer way to surface, it's more of a "nice to have". > I'll add a section and come up with a list of bullets for why you'd want to create a custom executor. If you have any to add, please reply with them here! Will do ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
