o-nikolas commented on PR #34324: URL: https://github.com/apache/airflow/pull/34324#issuecomment-1736099421
> Looks really good. Very well done! Just a comment, and I'm not sure how much can be done about this, but the Logging and CLI sections don't really add a lot of information about _how_ to log or vend CLI commands. I don't know what the process for that is, and whether that's something that should be discussed in a document like this. But if a bit more information (or links to examples from the LocalExecutor or Kubernetes Executor) can be added about that, it would help I think. Thanks for having a look @syedahsn I can try add a bit more info. But so far I've just mentioned which executors make use of it, rather than linking directly to code, since that link will very quickly become stale as changes are made to that class. Maybe I can put some pseudo code in here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
