eladkal commented on code in PR #34369:
URL: https://github.com/apache/airflow/pull/34369#discussion_r1325937553


##########
airflow/providers/google/cloud/transfers/gcs_to_samba.py:
##########


Review Comment:
   some might disagree but I would claim that samba is the higher intrest 
provider here
   
https://github.com/apache/airflow/blob/cf0c8245f54349fdcfe9ecdc19b34d8c71cfd479/CONTRIBUTING.rst#L1128
   
   so I believe this file should be in samba provider and not in google



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to