eladkal commented on code in PR #34369: URL: https://github.com/apache/airflow/pull/34369#discussion_r1326963767
########## airflow/providers/google/cloud/transfers/gcs_to_samba.py: ########## Review Comment: I look at this very differently. For me the most important thing is **user comfort**. Where users are likely to look for this integration. It should be simple and clear. We should not have completed rules. The shared goverance model does not bind google stackholders to contribute only to goolge provider. They can have intrest also in other providers. If Samba provider will not work then the google integration wont work regardless of where the class is located. I do think that we should finalize the policy around this cases. The blury rules make it so that we are challanging the policy with every PR. I'd be happy to start a mailing list thread after the summit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
