uranusjr commented on code in PR #34337:
URL: https://github.com/apache/airflow/pull/34337#discussion_r1327052913


##########
airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -146,6 +146,11 @@ def _get_relevant_upstream_map_indexes(upstream_id: str) 
-> int | range | None:
                 expanded_ti_count = _get_expanded_ti_count()
             except (NotFullyPopulated, NotMapped):
                 return None
+            if ti.map_index < 0:

Review Comment:
   I digged around a bit, this counts as expanded because there is indeed 
enough information to expand the operator, but the other depended task (`t2`) 
has not finished. This makes me think the fix is not right; we should 
investigate why `t2` is not considered relevant instead.
   
   The bug is in `_iter_upstream_conditions`, I think. Need more digging.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to