uranusjr commented on code in PR #34337:
URL: https://github.com/apache/airflow/pull/34337#discussion_r1327070066
##########
airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -146,6 +146,11 @@ def _get_relevant_upstream_map_indexes(upstream_id: str)
-> int | range | None:
expanded_ti_count = _get_expanded_ti_count()
except (NotFullyPopulated, NotMapped):
return None
+ if ti.map_index < 0:
Review Comment:
Yeah.
```
(Pdb) p
str(or_(*_iter_upstream_conditions(relevant_tasks=upstream_tasks)).compile(session.connection(),
compile_kwargs={"literal_binds": True}))
"task_instance.task_id = 't1' OR task_instance.task_id = 'tg1.t2' AND
task_instance.map_index < 0 OR task_instance.task_id = 'tg1.t2' AND
task_instance.map_index = -1"
```
This is not right; since `t3` does not depend on `t2` for mapping, it should
depend on all of its tis, not just -1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
