Owen-CH-Leung opened a new pull request, #34500:
URL: https://github.com/apache/airflow/pull/34500

   fixes #34482 
   
   kubelet client will not remove pods for us. So after removing istio sidecar, 
we will have to explicitly remove the pod also.
   
   Now when the base container return exit code 1 (i.e. error) and `delete_pod` 
is passed in, it will delete the pod after killing the sidecar. See below 
screen recording
   
   
https://github.com/apache/airflow/assets/43698890/657f51b9-5521-4309-925f-7df06603934e
   
   And when the base container return exit code 1 and `delete_succeeded_pod` is 
passed in, it will not delete the pod.
   
   
https://github.com/apache/airflow/assets/43698890/c7af3e9f-2192-4e12-9e1e-6d24d5e7b810
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to