jedcunningham commented on code in PR #34500:
URL: https://github.com/apache/airflow/pull/34500#discussion_r1334817805
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -822,8 +823,12 @@ def process_pod_deletion(self, pod: k8s.V1Pod, *,
reraise=True):
self.log.info("Deleting pod: %s", pod.metadata.name)
self.pod_manager.delete_pod(pod)
elif should_delete_pod and istio_enabled:
- self.log.info("Deleting istio-proxy sidecar inside %s: ",
pod.metadata.name)
- self.kill_istio_sidecar(pod)
+ if container_is_running(pod, self.ISTIO_CONTAINER_NAME):
+ self.log.info("Deleting istio-proxy sidecar inside %s:
", pod.metadata.name)
+ self.kill_istio_sidecar(pod)
+ self.pod_manager.delete_pod(pod)
+ else:
+ self.pod_manager.delete_pod(pod)
Review Comment:
```suggestion
self.pod_manager.delete_pod(pod)
```
Doesn't the sidecar listen to sigterm from k8s? In fact this whole thing can
be simplified further, if so (no need to see if an istio sidecar is running).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
